Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: implement code-editor input and simple-html module #70

Merged
1 commit merged into from
Jul 6, 2018

Conversation

eri-trabiccolo
Copy link
Collaborator

fixes #59

@ghost
Copy link

ghost commented Jul 6, 2018

Adding a new module type which includes a new input type requires unfortunately 10 files to modify / create at the moment.
I'll try to reduce this complexity for the future. A first simplification would be to specify the module's localized js params when registering the module in php, which is possible but we don't use it for the Nimble module for the moment. <= this way we wouldn't have to modify the inc/sektions/_dev_php/1_0_0_sektions_customizer_assets.php. one file less !

@ghost ghost merged commit ad7b658 into presscustomizr:master Jul 6, 2018
@eri-trabiccolo
Copy link
Collaborator Author

ah yeah, that file less would definitely change my life! :P
Thanks!

@ghost
Copy link

ghost commented Jul 6, 2018

yes, I'm being totally altruist there. I know. and I know it touches the very christian part of your soul.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Html code module prototype
1 participant