Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html code module prototype #59

Closed
ghost opened this issue Jul 3, 2018 · 4 comments · Fixed by #70
Closed

Html code module prototype #59

ghost opened this issue Jul 3, 2018 · 4 comments · Fixed by #70
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jul 3, 2018

Spec

  • the input tmpl should be composed one textarea input type
  • the fmk input type name is html_editor, and will be added in this file assets/czr/sek/js/_dev_control/_7_0_sektions_add_inputs_to_api.js
  • use the wp.codeEditor.initialize() see wp-admin/js/customize-control.js#5270, to turn this textarea into an editor
  • sanitization on save and output validation => see how the wp hmlt widget does it.
@ghost ghost added the enhancement New feature or request label Jul 3, 2018
@ghost ghost assigned eri-trabiccolo Jul 3, 2018
@ghost
Copy link
Author

ghost commented Jul 4, 2018

see #35 for the updated workflow

@eri-trabiccolo
Copy link
Collaborator

I'm using the already present simple_html_* php files at the moment, is it fine for you?

@ghost
Copy link
Author

ghost commented Jul 4, 2018

see #64 for the input_type addition workflow

@eri-trabiccolo
Copy link
Collaborator

Hi @Nikeo let me know what you think about this, when you can.
Then I need to share some thoughts about the code-editor (codemirror) use, and required assets.

@ghost ghost closed this as completed in #70 Jul 6, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant