Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pixi exec --list #3311

Merged
merged 7 commits into from
Mar 11, 2025
Merged

feat: pixi exec --list #3311

merged 7 commits into from
Mar 11, 2025

Conversation

lucascolley
Copy link
Contributor

closes gh-3303

lucascolley
lucascolley commented Mar 10, 2025
View reviewed changes
lucascolley
lucascolley commented Mar 10, 2025
View reviewed changes
@Hofer-Julian
fix: exec --list
22333e7 
- Make "=" required for `--list`
- Encapsulate functionality
- Clean up code
@Hofer-Julian
Add rust-src to build feature
cbdc9e7
@Hofer-Julian
Copy link
Contributor

@lucascolley nice work!
I pushed to your branch with the following changes:

  • Make "=" required for --list (otherwise list wouldn't work without a given regex, since it would think the command is the regex)
  • Move rust-src dependency
  • Encapsulate functionality
  • Clean up code

@Hofer-Julian Hofer-Julian marked this pull request as ready for review March 11, 2025 10:36
lucascolley
lucascolley commented Mar 11, 2025
View reviewed changes
Copy link
Contributor Author

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Hofer-Julian, all looks good to me!

Hofer-Julian
Hofer-Julian approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lucascolley 🚀

@Hofer-Julian Hofer-Julian merged commit 5edd7d8 into prefix-dev:main Mar 11, 2025
32 checks passed
@lucascolley
Copy link
Contributor Author

thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: pixi exec --list
2 participants
@lucascolley @Hofer-Julian