Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ipc override from options and give it manually to test #2629

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Dec 3, 2024

If I understand correctly, creating the IPC backend from a "string" will not be easily possible, and the types used are not serializable or cloneable.

I envision a future were we can override build backends selectively, and so it would be good to be able to use a hash map such as:

pixi-build-rattler-build: /foo/bar/pixi-build-rattler-build-test
bla: ...

But to achieve this, we need a type that is easier to use than the current Io backend. Since that backend override is only used in testing, we can use more direct methods of setting it in the Protocol.

Lmk what you think @tdejager / @baszalmstra

@baszalmstra baszalmstra enabled auto-merge (squash) December 3, 2024 14:09
@baszalmstra baszalmstra merged commit 869a429 into prefix-dev:main Dec 3, 2024
22 checks passed
@wolfv wolfv deleted the refactor-ipc-override branch December 3, 2024 14:30
@wolfv
Copy link
Member Author

wolfv commented Dec 3, 2024

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants