Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a venv for SU2 tutorials #593

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Create a venv for SU2 tutorials #593

merged 2 commits into from
Nov 15, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Nov 15, 2024

A first attempt to fix precice/su2-adapter#44 (here, to avoid understanding the structure and installation process of SU2 for now). I would keep the original issue open to find a better solution.

The ugly part is that this provides a requirements.txt for a directory that does not provide a code.

@IshaanDesai this seems to work in the system tests (at least for the perpendicular-flap, I have not tried out the flow-over-heated-plate). Do you see anything wrong in the code?

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH requested a review from IshaanDesai November 15, 2024 07:54
@MakisH MakisH self-assigned this Nov 15, 2024
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine 👍

@MakisH MakisH merged commit dd1f9c4 into develop Nov 15, 2024
1 check passed
@MakisH MakisH deleted the debug-su2 branch November 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt missing
2 participants