Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
colintucker committed Jan 9, 2018
2 parents 5c3a52d + 5b33d5d commit e49f706
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 20 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,9 @@ for more information.

## Maintainers

[![Colin Tucker](https://avatars3.githubusercontent.com/u/1853705?s=144)](https://github.com/colintucker) | [![Praxis Interactive](https://avatars2.githubusercontent.com/u/1782612?s=144)](http://www.praxis.net.au)
[![Colin Tucker](https://avatars3.githubusercontent.com/u/1853705?s=144)](https://github.com/colintucker) | [![Praxis Interactive](https://avatars2.githubusercontent.com/u/1782612?s=144)](https://www.praxis.net.au)
---|---
[Colin Tucker](https://github.com/colintucker) | [Praxis Interactive](http://www.praxis.net.au)
[Colin Tucker](https://github.com/colintucker) | [Praxis Interactive](https://www.praxis.net.au)

## License

Expand Down
2 changes: 1 addition & 1 deletion client/dist/styles/bundle.css

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions client/src/styles/components/ContentComponent.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,14 @@

}

> div.content {

&:after {
content: "";
display: table;
clear: both;
}

}

}
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"name": "Colin Tucker",
"role": "Developer",
"email": "colin@praxis.net.au",
"homepage": "http://www.praxis.net.au"
"homepage": "https://www.praxis.net.au"
}
],
"require": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{
"name": "Colin Tucker",
"email": "colin@praxis.net.au",
"url": "http://www.praxis.net.au"
"url": "https://www.praxis.net.au"
}
],
"repository": {
Expand Down
25 changes: 16 additions & 9 deletions src/Extensions/Model/ImageResizeExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

namespace SilverWare\Extensions\Model;

use SilverStripe\Assets\File;
use SilverStripe\Assets\Image;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\FieldList;
Expand Down Expand Up @@ -95,18 +96,24 @@ public function updateFieldLabels(&$labels)
/**
* Answers a resized image using the defined dimensions and resize method.
*
* @param Image $image Image object to be resized.
* @param File $image Image object to be resized.
*
* @return Image
* @return File
*/
public function performImageResize(Image $image)
public function performImageResize(File $image)
{
return $this->tools()->resize(
$image,
$this->owner->ImageResizeWidth,
$this->owner->ImageResizeHeight,
$this->owner->ImageResizeMethod
);
if ($image instanceof Image) {

return $this->tools()->resize(
$image,
$this->owner->ImageResizeWidth,
$this->owner->ImageResizeHeight,
$this->owner->ImageResizeMethod
);

}

return $image;
}

/**
Expand Down
7 changes: 1 addition & 6 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,7 @@ const rules = (env) => {
loader: 'postcss-loader'
},
{
loader: 'sass-loader',
options: {
includePaths: [
path.resolve(process.env.PWD, '../') // allows resolving of framework paths in symlinked modules
]
}
loader: 'sass-loader'
}
])
},
Expand Down

0 comments on commit e49f706

Please sign in to comment.