Add dynamic labels for DMA form flow results #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Dec 12, 2024
Onboarding/QA/flows/dma-form.md
Outdated
| # TODO: remove this hard-coding once we can have dynamic labels for flow results | ||
| write_result("mnch_onboarding_dma_form_v1.0_completed", "yes") | ||
| slug_end = concatenate(slug, "_", version, "_end") | ||
| write_result("slug", "@assessment_data.slug", label: "@slug_end") |
There was a problem hiding this comment.
Could we rather have the answer key be end instead of slug? To keep the naming consistent.
Onboarding/QA/flows/dma-form.md
Outdated
| result_tag = concatenate("@slug", "_", "@version", "_question") | ||
| write_result("question", question.question, label: "@result_tag") | ||
| result_tag = concatenate("@slug", "_", "@version", "_", "@question_id") | ||
| write_result("@result_tag", "@question_response") |
There was a problem hiding this comment.
I think we need to change this one to also using a label, so that we don't have @result_tag as the question key.
added 2 commits
December 17, 2024 11:16
rudigiesler
approved these changes
Dec 17, 2024
rudigiesler
added a commit
to praekeltfoundation/contentrepo-base-flow
that referenced
this pull request
Dec 24, 2024
This pulls the changes from praekeltfoundation/platform-mnch#64 into this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds dynamic labels to flow results. DS has been asked and first indications are that they approve.