Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to see that edd gets written to flow results #56

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add a check to see that edd gets written to flow results #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70549b6
Add a check to see that edd gets written to flow results
Oct 21, 2024
81c7750
Merge branch 'main' into fix-edd-reminders
Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: praekeltfoundation/flow_tester
ref: v0.3.0
ref: v0.3.5
path: flow_tester
ssh-key: ${{ secrets.SSH_PRIVATE_KEY }}

Expand Down
2 changes: 1 addition & 1 deletion Onboarding/QA/tests/edd-reminders_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ defmodule EDDRemindersTest do
text: ^edd_confirmation_text,
})
|> contact_matches(%{"edd" => ^full_edd})
# TODO: Add a test for the write_result
|> result_matches(%{name: "edd", value: ^full_edd})
end

test "edd confirmed -> main menu" do
Expand Down
4 changes: 4 additions & 0 deletions Onboarding/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ Pull requests are welcome. For major changes, please open an issue first to disc

Please make sure to update tests as appropriate.

## Tests

Running the tests requires elixir >= 1.17 (for Date.shift)

## Opening Journey as Markdown
You can open a Turn Journey as a markdown file by taking the url, removing `/app` and appending `?format=md`. A one click solution is to add the following code as a bookmark

Expand Down
Loading