Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ghostty to list of terminal bundle identifiers #1765

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

jimeh
Copy link
Contributor

@jimeh jimeh commented Dec 28, 2024

Ghostty is a new terminal emulator by mitchellh.

@tekezo
Copy link
Member

tekezo commented Dec 28, 2024

Thank you!
The js file is processed by the Duktape engine, which does not support backticks (`). Could you please change them to single quotes (’) instead?

@jimeh jimeh force-pushed the add-ghostty-to-terminal-list branch from 4367d70 to ec84923 Compare December 28, 2024 02:05
@jimeh
Copy link
Contributor Author

jimeh commented Dec 28, 2024

🤦‍♂️...they were supposed to be single-quotes originally. I guess that's what I get for using a quick toggle-quotes command in Emacs while half-asleep... lol

@jimeh jimeh force-pushed the add-ghostty-to-terminal-list branch from ec84923 to 47d919d Compare December 28, 2024 02:44
@tekezo tekezo merged commit e53154d into pqrs-org:main Dec 28, 2024
1 check passed
@tekezo
Copy link
Member

tekezo commented Dec 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants