Replace ucte-x-node-code with pairing_key #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinepiloquet
commented
Feb 8, 2024
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
EtienneLt
force-pushed
the
deprecate_ucte_x_node
branch
from
54c5623 to
ae99006
Compare
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
force-pushed
the
deprecate_ucte_x_node
branch
from
ae99006 to
3375e9a
Compare
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Update
What is the current behavior?
Dangling lines have a field ucte-x-node-code
What is the new behavior (if this is a feature change)?
This field is renamed pairing_key and ucte-x-node-code is deprecated
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
When creating a dangling line, the column or keyword argument
ucte-x-node-codeshould be replaced bypairing_key.When accessing the field from the dangling dataframe, the name of the column is also updated to
pairing_key.