[Network modifications] Fix: no exception should be thrown if boolean throwException is false #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be tested on creation of elements without bay |
EtienneLt
changed the title
EtienneLt
changed the title
colinepiloquet
changed the title
EtienneLt
force-pushed
the
fix_throw_exception_create_feeder_bay
branch
2 times, most recently
from
0077a17 to
054af21
Compare
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
force-pushed
the
fix_throw_exception_create_feeder_bay
branch
from
054af21 to
04cc366
Compare
EtienneLt
added
status: ready to be merged
bug
EtienneLt
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The boolean raise_exception is ignored when using network modifications.
What is the new behavior (if this is a feature change)?
When creating a feeder bay, if the boolean is true, an exception will be thrown, same for the creation of a line or a two windings transformer.
Does this PR introduce a breaking change or deprecate an API?