Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OpenReac optimization tests #83

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Nov 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

The optimization tests of OpenReac are refactored.

What is the current behavior?

All the tests are in the same file.

What is the new behavior (if this is a feature change)?
The tests have been divided into several files.
This will facilitate the adding of new tests in the future.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
@p-arvy p-arvy changed the title [WIP] Refactor OpenReac optimization tests Refactor OpenReac optimization tests Dec 12, 2024
@p-arvy p-arvy requested a review from So-Fras December 19, 2024 09:39
@p-arvy p-arvy added the Java label Dec 19, 2024
@p-arvy p-arvy self-assigned this Dec 19, 2024
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring the tests!

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
@p-arvy p-arvy requested a review from So-Fras December 30, 2024 11:24
@So-Fras So-Fras merged commit a1a48c5 into main Jan 8, 2025
7 checks passed
@So-Fras So-Fras deleted the refactor-open-reac-tests branch January 8, 2025 09:00
@So-Fras So-Fras restored the refactor-open-reac-tests branch January 8, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants