Add voltage level limit checks against the nominal voltage #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that high voltage limit is greater than nominal voltage. Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
So-Fras
requested changes
Apr 17, 2024
...src/test/java/com/powsybl/openreac/parameters/input/VoltageLevelLimitsOverrideInputTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/powsybl/openreac/parameters/input/VoltageLevelLimitsOverrideInputTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/powsybl/openreac/parameters/input/VoltageLevelLimitsOverrideInputTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/powsybl/openreac/parameters/input/VoltageLevelLimitsOverrideInputTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
So-Fras
approved these changes
Apr 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
When overriding the voltage level limits, checks are done to verify that the low voltage limit is less than the high voltage limit, and an exception is thrown if it's not the case, and no optimization is launched.
But no check is done to verify that the low voltage limit is less than the nominal voltage, and also to verify that the high voltage limit is greater than the nominal voltage. The consequence is that the optimization is launched and an error similar to the following is produced :
Voltage init has failed : com.powsybl.commons.PowsyblException: Error
during the execution in directory /tmp/ampl_13618596196810462793 exit
codes: Task 0 : 2
What is the new behavior (if this is a feature change)?
Checks are added and an exception is now thrown if the low voltage limit is greater than the nominal voltage, and if the high voltage limit is less than the nominal voltage.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: