Refactor resource image and documentation #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismirlia
reviewed
Mar 11, 2024
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{helpers.JobStatusQueued, helpers.JobStatusReadyForProcessing, helpers.JobStatusInProgress, helpers.JobStatusRunning, helpers.JobStatusWaiting}, | ||
| Target: []string{helpers.JobStatusCompleted, helpers.JobStatusFailed}, | ||
| Pending: []string{Arg_JobStatusQueued, Arg_JobStatusReadyForProcessing, Arg_JobStatusInProgress, Arg_JobStatusRunning, Arg_JobStatusWaiting}, |
There was a problem hiding this comment.
So these aren't arguments to the terraform resource, and the value of them should not be changed. Make a new section for the status constants. Something like:
Status_Queued = "queued"
Status_InProgress = "in_progress"
...
ismirlia
reviewed
Mar 11, 2024
| Pending: []string{"retry", helpers.PIImageQueStatus}, | ||
| Target: []string{helpers.PIImageActiveStatus}, | ||
| Pending: []string{"retry", Arg_ImageQueStatus}, | ||
| Target: []string{Arg_ImageActiveStatus}, |
michaelkad
requested changes
Mar 25, 2024
| log.Printf("Waiting for Power Image (%s) to be available.", id) | ||
|
|
||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{"retry", helpers.PIImageQueStatus}, | ||
| Target: []string{helpers.PIImageActiveStatus}, | ||
| Pending: []string{"retry", Image_Questatus}, |
There was a problem hiding this comment.
PIImageQueStatus = "queued"
| Pending: []string{"retry", helpers.PIImageQueStatus}, | ||
| Target: []string{helpers.PIImageActiveStatus}, | ||
| Pending: []string{"retry", Image_Questatus}, | ||
| Target: []string{Image_ActiveStatus}, |
There was a problem hiding this comment.
PIImageActiveStatus = "active"
| @@ -381,9 +379,9 @@ func waitForIBMPIJobCompleted(ctx context.Context, client *st.IBMPIJobClient, jo | |||
| log.Printf("[DEBUG] get job failed with empty response") | |||
| return nil, "", fmt.Errorf("failed to get job status for job id %s", jobID) | |||
| } | |||
| if *job.Status.State == helpers.JobStatusFailed { | |||
| if *job.Status.State == Status_Failed { | |||
There was a problem hiding this comment.
JobStatusFailed = "failed"
|
Opened #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: