Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image list-catalog data source and documentation #23

Closed
wants to merge 9 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title Catalog-refactor images Catalog-refactor image data source and documentation Dec 28, 2023
@ismirlia ismirlia changed the title Catalog-refactor image data source and documentation Refactor image list-catalog data source and documentation Jan 2, 2024
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Diptipowervs Diptipowervs requested a review from ismirlia January 4, 2024 20:26
ismirlia
ismirlia previously approved these changes Jan 5, 2024
@ismirlia
Copy link
Collaborator

ismirlia commented Jan 5, 2024

I think this looks good, if @michaelkad approves, open the PR in the main terraform repo for merging there.

Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
ismirlia
ismirlia previously approved these changes Jan 5, 2024
@ismirlia ismirlia requested a review from michaelkad January 5, 2024 22:54
michaelkad
michaelkad previously approved these changes Jan 5, 2024
@ismirlia
Copy link
Collaborator

ismirlia commented Jan 9, 2024

@Diptipowervs Since @michaelkad approved now could you open this pull request in the main terraform provider repo to get this ready to merge?

@ismirlia ismirlia dismissed stale reviews from michaelkad and themself via ec70621 January 12, 2024 15:06
@Diptipowervs
Copy link
Author

PR opened in main

@michaelkad michaelkad deleted the catalog-refactor branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants