Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SourcePort, DestinationPort to NSG rule resource #192

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add SourcePort, DestinationPort to NSG rule resource #192

wants to merge 9 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Jan 27, 2025 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_network_security_group_rule (r)

--- PASS: TestAccIBMPINetworkSecurityGroupRuleBasic (95.93s)
PASS

--- PASS: TestAccIBMPINetworkSecurityGroupRuleTCP (94.19s)
PASS

--- PASS: TestAccIBMPINetworkSecurityGroupRulePorts (96.09s)
PASS

@Alexander-Kita Alexander-Kita changed the title Add new sdk attributes Add SourcePort, DestinationPort, add workspace params Jan 27, 2025
@Alexander-Kita Alexander-Kita changed the title Add SourcePort, DestinationPort, add workspace params Add SourcePort, DestinationPort, add pi_workspace params Jan 27, 2025
@Alexander-Kita @ismirlia
Apply suggestions from code review
557eab8 
Co-authored-by: ismirlia <90468712+ismirlia@users.noreply.github.com>
ismirlia
ismirlia previously approved these changes Jan 27, 2025
View reviewed changes
@Alexander-Kita Alexander-Kita changed the title Add SourcePort, DestinationPort, add pi_workspace params Add SourcePort, DestinationPort Jan 27, 2025
@Alexander-Kita Alexander-Kita changed the title Add SourcePort, DestinationPort Add SourcePort, DestinationPort to NSG rule resource Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad approved these changes

@ismirlia ismirlia ismirlia approved these changes

Assignees
No one assigned
Labels
Feature Q1 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @michaelkad @ismirlia