Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forcenew field markings for instance #19

Closed
wants to merge 4 commits into from

Conversation

ismirlia
Copy link
Collaborator

Do these look like all the fields we want to mark forceNew. I'm not 100% on this.

@michaelkad and @yussufsh what are your opinions on this.
This pull request in response to: IBM-Cloud#4901

@ismirlia ismirlia marked this pull request as ready for review December 13, 2023 21:56
ismirlia and others added 2 commits December 13, 2023 17:15
The image id you pass in does not match the image id of the instance
created, so if you apply twice in row terraform thinks it has to
remake the instance when that's not true.
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ismirlia
Copy link
Collaborator Author

ismirlia commented Jan 5, 2024

Opening in main terraform provider, closing in this one.

@ismirlia ismirlia closed this Jan 5, 2024
@michaelkad michaelkad deleted the forcenew-instance-fields branch May 28, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants