Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume clone resource and data source #11

Closed

Conversation

dhirendersingh19
Copy link
Collaborator

@dhirendersingh19 dhirendersingh19 commented Oct 25, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

=== RUN   TestAccIBMPIVolumeClone
--- PASS: TestAccIBMPIVolumeClone (306.00s)
PASS
=== RUN   TestAccIBMPIVolumeClone_basic
--- PASS: TestAccIBMPIVolumeCloneTask_basic (18.13s)
PASS
=== RUN   TestAccIBMPIVolumeGroupUpdate
--- PASS: TestAccIBMPIVolumeGroupUpdate (537.88s)
PASS
...

michaelkad
michaelkad previously approved these changes Oct 26, 2023
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhirendersingh19
Copy link
Collaborator Author

Apologies, @michaelkad , for adding new commits. The newly added commit addresses @ismirlia comment. @michaelkad , I would like to kindly request a review of the PR once again

powervs-ibm
powervs-ibm previously approved these changes Dec 11, 2023
Copy link
Owner

@powervs-ibm powervs-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- Just have to resolve conflicts. After GA you can push those changes to the main repo.

@powervs-ibm
Copy link
Owner

@dhirendersingh19 do update power-go-client to v1.5.6 and push your changes to the main repo. SB has pushed to prod today.

@michaelkad
Copy link
Collaborator

This have been merged already, closing.

@michaelkad michaelkad closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants