Add a new optional graph description #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graph() accepts a new optional "desc" parameter. If provided, it will be included in the hover help before the per-metric description. As an example, the "Backend age" graphs now mention that autovacuum worker are included in the graph as this should be modified soon.
|
What do you think about this layout?
|
|
I'm fine with it. Do you want to apply extra change on this PR? I'm also interested in a review of the changes themselves outside of what CSS style to apply. I literally know nothing about the new dependencies so I just made random changes until it looked like it worked. |
|
I just added a fixup commit. Please squash commits and merge if it suits you. |
pgiraud
approved these changes
Feb 15, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph() accepts a new optional "desc" parameter. If provided, it will be included in the hover help before the per-metric description.
As an example, the "Backend age" graphs now mention that autovacuum worker are included in the graph as this should be modified soon.