Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run styler on the whole codebase #236

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Run styler on the whole codebase #236

merged 1 commit into from
Apr 16, 2024

Conversation

nealrichardson
Copy link
Collaborator

My editor formats on save, and that means when I touch one line in a file, it makes a big diff. So let's just run styler on the whole package and get it over with. No sense in arguing with the robots about what correct code style is.

@jonkeane
Copy link
Contributor

I'm fine with this, but to confirm: does your editor format in a style that styler agrees wtih?

@nealrichardson
Copy link
Collaborator Author

I'm fine with this, but to confirm: does your editor format in a style that styler agrees wtih?

Yes, VSCode uses styler: https://github.com/REditorSupport/languageserver?tab=readme-ov-file#customizing-formatting-style

@nealrichardson
Copy link
Collaborator Author

nealrichardson commented Apr 16, 2024

I have a (now) one-line fix for the pkgdown failure that I'll follow this with. And I'll also separately try to rectify the spelling issue (triggered in the coverage job), it needs updating anyway.

@nealrichardson nealrichardson merged commit 4f394d5 into main Apr 16, 2024
11 of 13 checks passed
@nealrichardson nealrichardson deleted the styler branch April 16, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants