You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm taking some time to try and do some clean up chores here (clean lint errors, see if we can reduce the heav(ier) dependencies, that kind of thing). I've tried following the top ofhttps://github.com/rstudio/connectapi/blob/main/.github/CONTRIBUTING.md to get tests (and especially integration tests, since that is touching the code I'm looking at) running.
In that process, I've noticed that the version of connect + connect image + R needed bumping. I'm happy to send a PR with those updates to the Makefile and docker-compose files but it also had me wondering if I'm missing a better way that folks are running these?
The text was updated successfully, but these errors were encountered:
I think you're on the right track. Unfortunately ever since I moved to an M1 mac, I have not been able to make much use of the integration tests locally 😅 So things have definitely fallen into disrepair.
(Probably a separate issue) but we should add some tests with mock API responses so we can get test coverage without having to run integration tests against a live connect server.
I'm taking some time to try and do some clean up chores here (clean lint errors, see if we can reduce the heav(ier) dependencies, that kind of thing). I've tried following the top ofhttps://github.com/rstudio/connectapi/blob/main/.github/CONTRIBUTING.md to get tests (and especially integration tests, since that is touching the code I'm looking at) running.
In that process, I've noticed that the version of connect + connect image + R needed bumping. I'm happy to send a PR with those updates to the Makefile and docker-compose files but it also had me wondering if I'm missing a better way that folks are running these?
The text was updated successfully, but these errors were encountered: