Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development flow clean ups? #214

Closed
jonkeane opened this issue Mar 1, 2024 · 3 comments · Fixed by #266
Closed

Development flow clean ups? #214

jonkeane opened this issue Mar 1, 2024 · 3 comments · Fixed by #266

Comments

@jonkeane
Copy link
Contributor

jonkeane commented Mar 1, 2024

I'm taking some time to try and do some clean up chores here (clean lint errors, see if we can reduce the heav(ier) dependencies, that kind of thing). I've tried following the top ofhttps://github.com/rstudio/connectapi/blob/main/.github/CONTRIBUTING.md to get tests (and especially integration tests, since that is touching the code I'm looking at) running.

In that process, I've noticed that the version of connect + connect image + R needed bumping. I'm happy to send a PR with those updates to the Makefile and docker-compose files but it also had me wondering if I'm missing a better way that folks are running these?

@colearendt
Copy link
Contributor

I think you're on the right track. Unfortunately ever since I moved to an M1 mac, I have not been able to make much use of the integration tests locally 😅 So things have definitely fallen into disrepair.

@nealrichardson
Copy link
Collaborator

(Probably a separate issue) but we should add some tests with mock API responses so we can get test coverage without having to run integration tests against a live connect server.

@nealrichardson
Copy link
Collaborator

#223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants