Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement additional scale options #976

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

uvera
Copy link
Contributor

@uvera uvera commented Feb 14, 2025

Designed like here #924

image
image

This code isn't really ideal since I had to sync both slider and dropdown (and I'm still learning Rust 😄 ).

Also no gif/video since my OBS is acting up weird 🤷

Signed-off-by: Dusan <dusanuveric@protonmail.com>
@uvera uvera force-pushed the feature-additional-scale-options branch from 6aa692e to 505a997 Compare February 14, 2025 17:00
@mmstick
Copy link
Member

mmstick commented Feb 14, 2025

Figma designs show only 5 breakpoints. So there's too many here.

@mmstick
Copy link
Member

mmstick commented Feb 14, 2025

I'm wondering if the slider should only adjust the selected scale from the dropdown instead of the slider being the whole spectrum of values.

@uvera
Copy link
Contributor Author

uvera commented Feb 14, 2025

Figma designs show only 5 breakpoints. So there's too many here.

Which values should be those breakpoints?

@mmstick
Copy link
Member

mmstick commented Feb 14, 2025

100, 150, 200, 250 would be less visually dense.

@uvera
Copy link
Contributor Author

uvera commented Feb 14, 2025

50, 112, 175, 237.5 and 300 are the values if we go for even distribution with 5 breakpoints.

image

50, 100, 150, 200, 250, 300 are the values with 6 breakpoints even distribution

Signed-off-by: Dusan <dusanuveric@protonmail.com>
@mmstick
Copy link
Member

mmstick commented Feb 14, 2025

You'll need to run cargo fmt

Signed-off-by: Dusan <dusanuveric@protonmail.com>
@mmstick mmstick merged commit 66a9507 into pop-os:master Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants