Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR #84

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Add QR #84

merged 5 commits into from
Jan 4, 2025

Conversation

mtao
Copy link
Contributor

@mtao mtao commented Jan 4, 2025

Adds SuiteSparse::SPQR and Eigen::SparseQR support

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (68aacce) to head (7bdb3eb).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/polysolve/linear/Solver.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   81.22%   82.04%   +0.81%     
==========================================
  Files          49       49              
  Lines        2008     2205     +197     
  Branches      268      269       +1     
==========================================
+ Hits         1631     1809     +178     
- Misses        377      396      +19     
Flag Coverage Δ
polysolve 82.04% <91.66%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teseoch teseoch merged commit e3b1e85 into polyfem:main Jan 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants