Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Improve Fee Token Verification & Asset ID Handling #11341

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ap211unitech
Copy link
Contributor

@ap211unitech ap211unitech commented Feb 28, 2025

📝 Description

This PR aims to fix -

  • Initial selectedAssetValue Update: Now initializing with -1 instead of 0, as non-native assets can have an asset ID of 0, which may cause issues like this.
  • Enhanced Fee Token Verification: Improved checks to ensure a chain implements sufficient fee token mechanism.
Screen.Recording.2025-02-28.at.09.47.04.mov

@darkfriend77
Copy link
Contributor

I tested the transfer on ajuna and it works again with the fix.

image

@ap211unitech
Copy link
Contributor Author

Great! It will be merged soon.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TarikGul TarikGul merged commit d1ac40d into master Feb 28, 2025
5 checks passed
@TarikGul TarikGul deleted the fix/fee-asset-checks branch February 28, 2025 11:27
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ajuna] runtime can't verify transaction anymore: wasm trapped
4 participants