Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error = FALSE argument to if_else2() #27

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Added error = FALSE argument to if_else2() #27

merged 3 commits into from
Dec 2, 2024

Conversation

dunkenwg
Copy link
Contributor

Also added more if_else2() tests

---
added more `if_else2()` tests
resolves #26
@dunkenwg
Copy link
Contributor Author

Failing on macos because it can't install R 4.4.2

Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth type checking the error argument (see suggested change.)

Also the error argument needs adding to the documentation.

R/if-else2.R Show resolved Hide resolved
Co-authored-by: Joe Thorley <joe@poissonconsulting.ca>
@dunkenwg
Copy link
Contributor Author

The error argument should be in the documentation

@dunkenwg dunkenwg requested a review from joethorley November 20, 2024 19:42
@dunkenwg
Copy link
Contributor Author

@aylapear, would you be able to take a look at this and I'll merge it in?

@aylapear aylapear merged commit e7bfde6 into main Dec 2, 2024
9 checks passed
@aylapear aylapear deleted the ifelse branch December 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants