Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing tests that failing due to changes in data (not bug in code) #74

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fixing tests that failing due to changes in data (not bug in code) #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e1aca
updating tests with minor differences in output numbers
joethorley Oct 25, 2024
8ae7ad7
skip test that failing as order can change!
joethorley Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,522 changes: 761 additions & 761 deletions tests/testthat/_snaps/add-gm-elevation-to-point/elevation.csv
View file
Open in desktop

Large diffs are not rendered by default.

388 changes: 194 additions & 194 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms.csv
View file
Open in desktop

Large diffs are not rendered by default.

388 changes: 194 additions & 194 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms_34.csv
View file
Open in desktop

Large diffs are not rendered by default.

386 changes: 193 additions & 193 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms_35.csv
View file
Open in desktop

Large diffs are not rendered by default.

1,670 changes: 835 additions & 835 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms_elev.csv
View file
Open in desktop

Large diffs are not rendered by default.

388 changes: 194 additions & 194 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms_inaccuracy.csv
View file
Open in desktop

Large diffs are not rendered by default.

388 changes: 194 additions & 194 deletions tests/testthat/_snaps/convert-streams-to-rms/fwa_convert_streams_to_rms_tinac.csv
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions tests/testthat/test-add-collection-to-polygon.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ test_that("fwa_add_collection_to_polygon function intersects work", {
"watershed_key_50k", "wscode_ltree", "geometry"))

expect_s3_class(x$geometry, "sfc_GEOMETRY")
expect_s3_class(x$geometry[[1]], "LINESTRING")
expect_identical(colnames(sf::st_coordinates(x$geometry[[1]])), c("X", "Y", "L1")) # why not , "Z", "L1"
})

test_that("fwa_add_collection_to_polygon function intersects works with named streams and keeps extras and deals other projection", {
Expand Down
9 changes: 5 additions & 4 deletions tests/testthat/test-add-gm-elevation-to-point.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ test_that("fwa_add_gm_elevation_to_point works few", {
expect_identical(colnames(x), c("blk", "rm", "elevation", "geometry"))
skip_on_os("linux")
expect_equal(x$elevation,
c(5, 5, 5, 5, 5, 10.4482297897339, 5.37834215164185, 5, 9.25851440429688,
7.17906618118286, 7.01196908950806, 8.31775856018066, 10.8424005508423,
10.237512588501, 11.2183532714844, 11.2872858047485, 10.5328788757324,
75.5071563720703, 165.420700073242, 208.490798950195))
c(5, 5, 5, 5, 5, 10.3936414718628, 5.35515594482422, 5.00018835067749,
9.28686714172363, 7.15812873840332, 7.00370025634766, 8.34566402435303,
10.8686275482178, 10.2142515182495, 11.205244064331, 11.2773637771606,
10.5231037139893, 75.4199447631836, 165.338165283203, 208.487548828125
))
})

test_that("fwa_add_gm_elevation_to_point works digits", {
Expand Down
8 changes: 4 additions & 4 deletions tests/testthat/test-snap-rm-to-point.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ test_that("fwa_snap_rm_to_point handles different projection", {
expect_equal(x$blk, rep(356308001, 5))
expect_equal(x$rm, c(1000, 3000, 4000, 4000, 8000))
skip_on_os("linux")
expect_equal(x$distance_to_rm, c(873.234910729237, 535.423300272613, 754.094196812846, 610.927151569317,
514.650461141983))
expect_equal(x$distance_to_rm, c(873.508858502692, 535.637650105008, 754.230245890098, 610.731097003085,
514.952511355012))
expect_s3_class(x$geometry, "sfc_POINT")
})

Expand All @@ -42,8 +42,8 @@ test_that("fwa_snap_rm_to_point handles different projection x", {
expect_equal(x$blk, rep(356308001, 5))
expect_equal(x$rm, c(1000, 3000, 4000, 4000, 8000))
skip_on_os("linux")
expect_equal(x$distance_to_rm, c(870.669835173722, 534.213451637178, 754.759413126628, 609.184795518874,
513.580260460033))
expect_equal(x$distance_to_rm, c(870.660879112366, 534.199200145354, 754.770979129562, 609.168343854411,
513.588145818887))
expect_s3_class(x$geometry, "sfc_POINT")
})

Expand Down
Loading