From 972d5c7ef77b0d47ad6da2affaad7233a22074ab Mon Sep 17 00:00:00 2001 From: "Christopher F. Auston" Date: Sat, 17 Jan 2015 11:14:43 -0600 Subject: [PATCH] converge_by is not needed when only platform resources are used (http://docs.chef.io/lwrp_custom_provider.html). converge_by always marks the custom resource as updated which may send spurious notifications when nothing actually changed. --- providers/service.rb | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/providers/service.rb b/providers/service.rb index 4c1d759..02dca51 100644 --- a/providers/service.rb +++ b/providers/service.rb @@ -19,18 +19,14 @@ # action :enable do - converge_by("Enabling #{ new_resource }") do - enable_service - end + enable_service end action :disable do if current_resource.state == 'UNAVAILABLE' Chef::Log.info "#{new_resource} is already disabled." else - converge_by("Disabling #{new_resource}") do - disable_service - end + disable_service end end