Fix some issues building for Library Evolution, Xcode 16 #234
Conversation
|
@stephencelis - this should be the last in the series from me 😄 |
|
I also took a stab at updating CI to address the error from the previous run (not finding the 17.5 simulator with Xcode 16 selected IIRC). Let me know what you think; a couple of ways to do this. |
|
Noting that this is working for me locally @stephencelis - might be worth a re-run. |
|
@stephencelis - what do you think about giving this one a re-rerun, given it's working for me locally ? (I don't have that button available in the UI). |
|
@gemmakbarlow I've been re-running but sadly GitHub actions just seem to be flakey. Here's hoping for a green run this time! |
|
@gemmakbarlow Sorry for the churn. I'm frustrated with CI and I think some of the changes I've made to your PR have made things worse in how the simulator is getting resolved. I'm not sure if you want to take another stab at fixing things, or if you want me to try again when I have time. |
|
All good - I can take a stab at fixing it, hopefully later tonight. |
gemmakbarlow
force-pushed
the
gemmakbarlow/xcode-16-library-evolution
branch
from
0398acd to
6655437
Compare
gemmakbarlow
force-pushed
the
gemmakbarlow/xcode-16-library-evolution
branch
from
6655437 to
eb13416
Compare
Reader, she did not get back to it later tonight - but she is hoping to spend some time on this today / tomorrow. |
gemmakbarlow
force-pushed
the
gemmakbarlow/xcode-16-library-evolution
branch
4 times, most recently
from
82a4dc1 to
da539ff
Compare
.github/workflows/ci.yml
Outdated
| steps: | ||
| - run: echo "Preparing Environment Variables..." | ||
| outputs: | ||
| XCODE_15_VERSION: 15.4 |
There was a problem hiding this comment.
A workaround, as environment variables are not usable within a matrix, annoyingly.
@stephencelis - thrilled to report I finally got back to this, and things are working. Splitting out the library evolution builds into a separate job allowed for them to be run against a more appropriate matrix, and seems to have solved the iOS version / Xcode version issues we were seeing previously. Further feedback welcomed. |
|
|
|
Friendly bump on this one when you get a minute @stephencelis |
gemmakbarlow
force-pushed
the
gemmakbarlow/xcode-16-library-evolution
branch
from
0fe3ec3 to
1c434e3
Compare
|
Friendly bump on this one when you get a minute @stephencelis |
…-library-evolution
There was a problem hiding this comment.
Sorry this has taken so long to merge, but thanks @gemmakbarlow for the PR!
No problem - thanks for getting it over the line ! ❤️ |
build-for-library-evolutionto CI