Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppKitNavigation - Common #209
AppKitNavigation - Common #209
Changes from 8 commits
e2c5db4
0c61b63
c2bdb0d
82c7737
8e5e4e6
2b91081
cad947b
e863c54
00ed18a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mx-Iris I've familiarized myself a bit more with this API by adding a configurable timing function, and it also occurred to me that because
withAppKitAnimation
is intended to be called from the model, whereview.animator
is not available, that it probably makes sense to always setallowsImplicitAnimation
totrue
. Does this sound right to you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's right.
NSView
/NSWindow
implements theNSAnimatablePropertyContainer
protocol. When the view'sframe
,size
, orposition
changes, it can produce animated effects. Through its animator, these properties can be used transparently to generate animations.Setting
NSAnimationContext
'sallowsImplicitAnimation
to true, directly modifying the view's properties will produce animations. This is kind of like UIKit'sUIView.animate
method. But only theframe
,frameSize
, andframeOrigin
properties are supported. More property animations require alayer-backed
view, that is, the view'swantsLayer
= true.This file was deleted.
This file was deleted.