Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic queries example #14

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Conversation

andtie
Copy link
Contributor

@andtie andtie commented Feb 17, 2025

The load-method is asynchronous and throwing.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just made a few small changes:

  • Made error handling more generic
  • Moved error handling into the helper method

@stephencelis stephencelis merged commit 15b5bd3 into pointfreeco:main Feb 17, 2025
2 checks passed
mbrandonw pushed a commit that referenced this pull request Feb 17, 2025
* Fix dynamic queries example

* Update Sources/SharingGRDB/Documentation.docc/Articles/DynamicQueries.md

* Update Sources/SharingGRDB/Documentation.docc/Articles/DynamicQueries.md

---------

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants