Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with linestring with less than 3 points failing to ingest in CMR #41

Open
jamesfwood opened this issue Jan 28, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jamesfwood
Copy link
Contributor

jamesfwood commented Jan 28, 2025

Around 25% of granules are failing.
Suggested fix: Add an extra point in the line to give it 3+ points.

Reported here:

https://wiki.jpl.nasa.gov/pages/viewpage.action?pageId=1047760594

SWOT NALT granules failing in forge since December 18th
Contemporaneous success/fail cases

collection: SWOT_L2_NALT_OGDR_2.0

successful granule: SWOT_OPR_2PfS027_025_20250114_140108_20250114_154122

failed granule: SWOT_OPR_2PfS027_027_20250114_154229_20250114_162717

"An error occurred in the Cumulus Message Adapter: java.lang.IllegalArgumentException: Ring has fewer than 3 points, so orientation cannot be determined"

$ java -cp ./footprint_0.10.0.jar FootprintCLI granules/SWOT_OPR_2PfS027_027_20250114_154229_20250114_162717.nc SWOT_L2_NALT_OGDR_2.0.cfg > test.txt

$ cat test.txt | grep "Process retrieved footprint" -A 1 > out.wkt

$ cat SWOT_OPR_2PfS027_027_20250114_154229_20250114_162717.wkt (ingest failed)

MULTILINESTRING ((19.9403 -23.1022, 27.4928 24.3991, 33.0238 45.3443, 36.959 53.7749, 41.7918 60.495, 47.808 65.8524, 55.1811 70.0057, 70.7739 74.6958, 91.9001 77.226, 117.9707 77.4506, 140.8738 75.1775, 155.1512 71.5736, 165.9668 66.1902, 173.9744 58.7027, 180 48.4088), (-180 48.4088, -178.8149 45.477)) <<< PROBLEM HERE

$ cat SWOT_OPR_2PfS027_025_20250114_140108_20250114_154122.wkt (ingest succeeded)

MULTILINESTRING ((46.7582 -17.8424, 53.0282 22.501, 57.7399 42.01, 60.8914 50.0237, 64.6427 56.6179, 69.089 61.975, 74.4699 66.3832, 82.4342 70.5879, 92.4623 73.776, 104.8163 76.0129, 119.6639 77.3308, 137.1218 77.6418, 154.1271 76.787, 168.4201 74.8779, 180 71.9343), (-180 71.9343, -171.6046 68.3104, -164.7619 63.5712, -159.2781 57.5706, -154.7985 49.9105, -151.2873 40.7214, -148.3058 29.1515, -139.7413 -23.3688, -134.7964 -43.1898, -131.0289 -52.0625, -126.4373 -59.1069, -120.7318 -64.7369, -113.7542 -69.1163, -105.3025 -72.452, -95.1172 -74.9167, -68.3411 -77.5396, -37.5618 -76.6712, -24.7803 -74.9254, -14.1496 -72.327, -7.2595 -69.676, -1.3748 -66.3796, 3.5214 -62.442, 7.7115 -57.6493, 14.2401 -45.1536, 19.1828 -27.0064))

@jamesfwood jamesfwood added the bug Something isn't working label Jan 28, 2025
@jamesfwood jamesfwood moved this to 🔖 Ready in hitide-25.1 Jan 28, 2025
@sliu008
Copy link
Contributor

sliu008 commented Jan 28, 2025

where is this happenings? seems like were able to generate the footprint, is it happening in the metadata aggregator step where we try to ensure the orientation of the points?

@ymchenjpl
Copy link

ymchenjpl commented Feb 4, 2025

Per Tim's email to Jack, here are more collections with good vs. bad Forge workflows:
From: Mcknight, Tim (US 398N-Affiliate) timothy.b.mcknight@jpl.nasa.gov
Sent: Tuesday, January 14, 2025 11:54 AM
Subject: <UPDATE - MORE INFO> Re: SWOT OPS - Getting alot of Forge errors on the SWOT_L2_NALT_GDR_2.0 and SWOT_L2_NALT_IDR_2.0 collections

Hi Jack,

There are forge executions from these 6 collections that are completing.
To get a rough estimate for the last 30 days for all of the 6 collections listed below (previous e-mail) 2439 Forge execution have failed and 7180 succeeded.

I'm listing a sample granule that succeeded along with it's collection so you can compare.

collection: SWOT_L2_NALT_OGDR_2.0
successful granule: SWOT_OPR_2PfS027_025_20250114_140108_20250114_154122
failed granule: SWOT_OPR_2PfS027_027_20250114_154229_20250114_162717

collection: SWOT_L2_NALT_IGDR_2.0
successful granule: SWOT_IPN_2PfP026_566_20250113_004821_20250113_013948
failed granule: SWOT_IPN_2PfP026_575_20250113_083122_20250113_092249

collection: SWOT_L2_RAD_IGDR_2.0
successful granule: SWOT_IPRAD_2PaP027_002_20250113_175718_20250113_184844_PIC2_01
failed granule: SWOT_IPRAD_2PaP026_575_20250113_083122_20250113_092249_PIC2_01

collection: SWOT_L2_RAD_OGDR_2.0
successful granule: SWOT_OPRAD_2PaS027_016_20250114_055921_20250114_061436_PIC2_01
failed granule: SWOT_OPRAD_2PaS026_496_20250110_125950_20250110_143509_PIC2_01

@ymchenjpl
Copy link

@sliu008 To answer your question, here is Tim's original email, and I've copied the steps in the Execution to show it failed on Step 26 below:

From: Mcknight, Tim (US 398N-Affiliate) timothy.b.mcknight@jpl.nasa.gov
Sent: Wednesday, December 18, 2024 9:28 AM
Subject: SWOT OPS - Getting alot of Forge errors on the SWOT_L2_NALT_GDR_2.0 and SWOT_L2_NALT_IDR_2.0 collections

Hi Jim and Simon,

Getting alot of these errors in Forge (627 today) Listing an example granule below.

granule: SWOT_IPR_2PfP025_373_20241216_063401_20241216_072528
execution: Execution: f3c9e2e8-13b3-4fbf-aac3-6250153bab04
collection: SWOT_L2_NALT_IGDR_2.0___2.0

error: {"errorMessage":"An error occurred in the Cumulus Message Adapter: java.lang.IllegalArgumentException: Ring has fewer than 3 points, so orientation cannot be determined"

Tim

AWS SWOT OPS Console - Forge Workflow - Execution f3c9e2e8-13b3-4fbf-aac3-6250153bab04

9 | ChoiceStateEntered | FootprintChoice |   | 00:00:00.287 | Dec 17, 2024, 11:42:46.309 (UTC-08:00)
10 | ChoiceStateExited | FootprintChoice |   | 00:00:00.287 | Dec 17, 2024, 11:42:46.309 (UTC-08:00)
11 | TaskStateEntered | FootprintBranching |   | 00:00:00.287 | Dec 17, 2024, 11:42:46.309 (UTC-08:00)
12 | LambdaFunctionScheduled | FootprintBranching | Lambda  | Log group | 00:00:00.287 | Dec 17, 2024, 11:42:46.309 (UTC-08:00)
13 | LambdaFunctionStarted | FootprintBranching |   | 00:00:00.325 | Dec 17, 2024, 11:42:46.347 (UTC-08:00)
14 | LambdaFunctionSucceeded | FootprintBranching |   | 00:00:00.630 | Dec 17, 2024, 11:42:46.652 (UTC-08:00)
15 | TaskStateExited | FootprintBranching |   | 00:00:00.648 | Dec 17, 2024, 11:42:46.670 (UTC-08:00)
16 | ChoiceStateEntered | FootprintBranchChoice |   | 00:00:00.648 | Dec 17, 2024, 11:42:46.670 (UTC-08:00)
17 | ChoiceStateExited | FootprintBranchChoice |   | 00:00:00.648 | Dec 17, 2024, 11:42:46.670 (UTC-08:00)
18 | TaskStateEntered | FootprintProcess |   | 00:00:00.648 | Dec 17, 2024, 11:42:46.670 (UTC-08:00)
19 | LambdaFunctionScheduled | FootprintProcess | Lambda  | Log group | 00:00:00.648 | Dec 17, 2024, 11:42:46.670 (UTC-08:00)
20 | LambdaFunctionStarted | FootprintProcess |   | 00:00:00.687 | Dec 17, 2024, 11:42:46.709 (UTC-08:00)
21 | LambdaFunctionSucceeded | FootprintProcess |   | 00:00:02.584 | Dec 17, 2024, 11:42:48.606 (UTC-08:00)
22 | TaskStateExited | FootprintProcess |   | 00:00:02.599 | Dec 17, 2024, 11:42:48.621 (UTC-08:00)
23 | TaskStateEntered | MetadataAggregator |   | 00:00:02.599 | Dec 17, 2024, 11:42:48.621 (UTC-08:00)
24 | LambdaFunctionScheduled | MetadataAggregator | Lambda  | Log group | 00:00:02.599 | Dec 17, 2024, 11:42:48.621 (UTC-08:00)
25 | LambdaFunctionStarted | MetadataAggregator |   | 00:00:02.637 | Dec 17, 2024, 11:42:48.659 (UTC-08:00)
26 | LambdaFunctionFailed | MetadataAggregator |   | 00:00:06.570 | Dec 17, 2024, 11:42:52.592 (UTC-08:00)

@jamesfwood
Copy link
Contributor Author

jamesfwood commented Feb 5, 2025

Another email from Tim:

Hi Jim and Simon,

Ops has recently cited seeing the "Ring has fewer than 3 points" error for these 6 SWOT collections in the Forge workflow.

SWOT_L2_RAD_IGDR_2.0
SWOT_L2_RAD_GDR_2.0
SWOT_L2_RAD_OGDR_2.0

SWOT_L2_NALT_IGDR_2.0
SWOT_L2_NALT_GDR_2.0
SWOT_L2_NALT_OGDR_2.0

Now in Cumulus Ops we are getting the same error for collection JASON_3_L2_OST_OGDR_GPS___F and G during the Forge workflow.

sample granule:
JA3_GPSOPR_2PgS501_046_20250203_084240_20250203_101321

error:

{"errorMessage":"An error occurred in the Cumulus Message Adapter: java.lang.IllegalArgumentException: Ring has fewer than 3 points, so orientation cannot be determined"

Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants