From 1b11300c12f4b8560b00a4caa91c7397af8781e0 Mon Sep 17 00:00:00 2001
From: Frank Greguska <Francis.Greguska@jpl.nasa.gov>
Date: Wed, 3 Apr 2024 10:10:21 -0700
Subject: [PATCH] Fix syntax error in entrypoint.sh

---
 CHANGELOG.md  |  1 +
 entrypoint.sh | 11 ++++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f686362..fa336a2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Deprecated
 ### Removed
 ### Fixed
+ - [issues/29](https://github.com/podaac/cmr-umm-updater/issues/29) Fix syntax error in entrypoint.sh
 ### Security
 
 ## [0.7.0]
diff --git a/entrypoint.sh b/entrypoint.sh
index a11cfe7..64483bd 100755
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -11,18 +11,19 @@ disable_removal=$6
 umm_type=$7
 use_associations=${8:-true}
 umm_version=$9
-url_value=$10
+url_value=${10}
 
 # Replace version placeholder with actual version
-jq --arg a $version '.Version = $a' "$file" > "cmr/cmr.json"
+jq --arg a "$version" '.Version = $a' "$file" > "cmr/cmr.json"
 
-if [[ -n "${url_value}"]]
 if [[ $url_value ]]; then
-  jq --arg a "${url_value}" '.URL.URLValue = $a' cmr/cmr.json > cmr/cmr.json.tmp && mv cmr/cmr.json.tmp cmr/cmr.json
+  jq --arg a "${url_value}" '.URL.URLValue = $a' cmr/cmr.json > cmr/cmr.json.tmp
+  mv cmr/cmr.json.tmp cmr/cmr.json
 else
   # Replace Harmony URL placeholder with Harmony URL based on env
   if [[ $env == "sit" || $env == "uat" ]]; then
-    jq --arg a "https://harmony.uat.earthdata.nasa.gov" '.URL.URLValue = $a' cmr/cmr.json > cmr/cmr.json.tmp && mv cmr/cmr.json.tmp cmr/cmr.json
+    jq --arg a "https://harmony.uat.earthdata.nasa.gov" '.URL.URLValue = $a' cmr/cmr.json > cmr/cmr.json.tmp
+    mv cmr/cmr.json.tmp cmr/cmr.json
   fi
 fi