Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

74 notes feature for photoinput and photo components #253

Merged
merged 18 commits into from
Feb 4, 2025
Merged

74 notes feature for photoinput and photo components #253

merged 18 commits into from
Feb 4, 2025

Conversation

lindsayJohnstonPnnl
Copy link
Collaborator

@lindsayJohnstonPnnl lindsayJohnstonPnnl commented Dec 18, 2024 •
edited
Loading

  • Added a notes section to every component
  • The section shows by default but can be turned "off" with
  • The component will show the read-only notes section if it exists for that group of photos

@lindsayJohnstonPnnl lindsayJohnstonPnnl linked an issue Dec 18, 2024 that may be closed by this pull request
Notes Feature for PhotoInput and Photo components #74
Closed
@lindsayJohnstonPnnl
Copy link
Collaborator Author

lindsayJohnstonPnnl commented Dec 18, 2024 •
edited
Loading

Example of Report Tab Photo with notes, and photo without notes:
image

Example of photo prompt without notes section and with notes section (With notes is default):
image

@lindsayJohnstonPnnl lindsayJohnstonPnnl marked this pull request as ready for review December 18, 2024 22:57
sudhacheran
sudhacheran requested changes Jan 7, 2025
View reviewed changes
src/components/photo_input.tsx Outdated Show resolved Hide resolved
src/components/photo_input.tsx Outdated Show resolved Hide resolved
src/components/photo_input_wrapper.tsx Outdated Show resolved Hide resolved
@sudhacheran
Copy link
Collaborator

The changes looks good to me. Thanks!

@sudhacheran sudhacheran merged commit 62096b9 into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhacheran sudhacheran sudhacheran approved these changes

@charliepnnl charliepnnl Awaiting requested review from charliepnnl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notes Feature for PhotoInput and Photo components
2 participants
@lindsayJohnstonPnnl @sudhacheran