Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-javascript project generates new version for every package #123

Open
jamescarignan opened this issue Jun 29, 2022 · 2 comments
Open

Comments

@jamescarignan
Copy link

Tools Info

semantic-release version: 19.0.3
semantic-release-monorepo version: 7.0.5

Issue

I'm building Python packages and using the semantic-release-pypi plugin to publish to a private PyPI repository. That is all working as expected. The problem I'm having is that any commit, anywhere in the project tree, is triggering a new version for every package in packages/.

semantic-release-monorepo is reporting that no relevant commits were found:
[semantic-release] [[Function: semantic-release-monorepo]] › ℹ Found 0 commits for package mypackage since last release

But as you can see below, semantic-release still thinks a new version is needed.

semantic-release:release-notes-generator previousTag: 'mypackage-v2.7.4' +0ms
semantic-release:release-notes-generator currentTag: 'mypackage-v2.7.5' +0ms
[semantic-release] › ⚠  Skip mypackage-v2.7.5 tag creation in dry-run mode

I'm not convinced this is necessarily an issue with the monorepo plugin, but I do have it working beautifully with some Angular libraries we're building and publishing. If I disable the PyPI plugin, there's no change in behaviour. Has anyone else experienced this same thing? I can put together an example repo if that would help.

@ankitbko
Copy link

Did you find solution for this?

@pmowrer
Copy link
Owner

pmowrer commented Jan 29, 2024

The logic in only-package-commits.js is package.json-specific. To support non-JS projects, the logic would have to be generalized/customizable somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants