Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine IP Address with Client ID (or something) for multiple players from same IP #49

Closed
drowe opened this issue Sep 24, 2019 · 3 comments
Closed

Combine IP Address with Client ID (or something) for multiple players from same IP #49

drowe opened this issue Sep 24, 2019 · 3 comments

Comments

@drowe
Copy link

drowe commented Sep 24, 2019

With the packet limiting portion (possibly also related to #32) - I have 3 clients connecting to my server from the same public IP - I think the rate limiting is based on the IP only, instead of a composite key of sorts with the IP and the client. Thus, enough activity from 3 players on the same IP - causes a server crash / IP ban with too many packets.
@dktapps
Copy link
Member

dktapps commented Sep 25, 2019

This would make it too easy to execute denial of service attacks.

@drowe
Copy link
Author

drowe commented Sep 28, 2019

Surely some balance could be reached? Say configuration for X number of clients using the same IP?

@dktapps dktapps closed this as completed Oct 14, 2019
@drowe
Copy link
Author

drowe commented Oct 14, 2019

@dktapps - what is the expected maximum number of clients per IP address - 1 player? Can/Should this be documented somewhere?

@dktapps dktapps mentioned this issue Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drowe @dktapps