Implemented Respawn Anchor #6646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think someone will find a use for this, but for now it's closed. |
|
It seems to have been fixed |
|
I checked php cs fixer locally but found no errors.. |
dktapps
reviewed
Mar 9, 2025
dktapps
reviewed
Mar 9, 2025
|
It seems like the generator starts and works. |
|
sad |
|
I don't understand how to remove the file change, maybe I should just recreate the PR? |
|
mm, that's it |
|
Is there any point in fixing this PHPStan? |
dktapps
reviewed
Mar 17, 2025
dktapps
reviewed
Mar 17, 2025
ipad54
reviewed
Mar 17, 2025
The explosion impact is calculated at this stage, so modifying this value will do nothing
ipad54
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR implements Respawn Anchor
this is just a contribution to the community
Related issues & PRs
Changes
API changes
With the added BlockExplodeEvent and BlockPreExplodeEvent classes, the poor documentation needs to be changed and stuf
Behavioural changes
When RespawnAnchor explodes, Average TPS may drop by 19.24+-. Well, the respawn anchor itself has a "delay" in the Explosion
Backwards compatibility
Follow-up
Tests
https://www.youtube.com/watch?v=aI3ZItR3FY8