feat: Better aes #35
Merged
feat: Better aes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These AES constructions come from crema labs implementation https://github.com/crema-labs/aes-circom which seems to be of much higher quality than the electron labs implementation. These are modular over key sizes, well documented, and have more testing, and are more constrained.
These circuits implement everything up to AES-CTR with any of FIPs compatible keys sizes.
I prepose we work to build our ghash and GCM implementation on top of this and perhaps then see if we can upstream those changes to the crema-labs work.