Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions of queued sentry messages #24

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fix permissions of queued sentry messages #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fb2067
Fix permissions of queued sentry messages
weakbit Jan 17, 2025
5445c1c
Proceed with rector changes
weakbit Jan 17, 2025
cbbd9c6
Update symfony/http-client dependency
weakbit Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,4 @@ jobs:
restore-keys: |
${{ runner.os }}-${{ matrix.php }}-composer-
- run: composer require typo3/minimal="^${{ matrix.typo3 }}" --dev
- run: composer install --no-interaction --no-progress
- run: ./vendor/bin/grumphp run --ansi
2 changes: 1 addition & 1 deletion Classes/Logger/BreadcrumbLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function writeLog(LogRecord $record): WriterInterface
LogLevel::NOTICE => Breadcrumb::LEVEL_INFO,
LogLevel::INFO => Breadcrumb::LEVEL_INFO,
LogLevel::DEBUG => Breadcrumb::LEVEL_DEBUG,
default => throw new Exception(sprintf('Log level not supported "%s"', $record->getLevel())),
default => throw new Exception(sprintf('Log level not supported "%s"', $record->getLevel()), 2001144362),
},
Breadcrumb::TYPE_DEFAULT,
$record->getComponent(),
Expand Down
1 change: 1 addition & 0 deletions Classes/Queue/FileQueue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ public function push(Entry $entry): void
}

@fwrite($fp, $data);
@GeneralUtility::fixPermissions($fileName);
@fclose($fp);
}
}
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"ext-fileinfo": "*",
"composer-runtime-api": "^2",
"http-interop/http-factory-guzzle": "^1.0",
"psr/log": "*",
"sentry/sentry": "^3.22.1",
"typo3/cms-core": "^11.5 || ^12.4",
"typo3/cms-frontend": "^11.5 || ^12.4"
Expand All @@ -22,7 +23,7 @@
"pluswerk/grumphp-config": "^7",
"saschaegerer/phpstan-typo3": "^1.10.0",
"ssch/typo3-rector": "^2.4.0",
"symfony/http-client": "^5.4 || ^6"
"symfony/http-client": "^5.4 || ^6.4"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 0 additions & 2 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
use PLUS\GrumPHPConfig\RectorSettings;
use Rector\Config\RectorConfig;
use Rector\Caching\ValueObject\Storage\FileCacheStorage;
use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->parallel();
Expand Down Expand Up @@ -34,7 +33,6 @@
...RectorSettings::skip(),
...RectorSettings::skipTypo3(),

FinalizeClassesWithoutChildrenRector::class,
ReadOnlyPropertyRector::class,
/**
* rector should not touch these files
Expand Down
Loading