🐛 fix pipeline issues

pluswerk · Jun 27, 2023 · 4cb4074 · 4cb4074
1 parent 542c596
commit 4cb4074
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Classes/Service/PdfGenerationService.php b/Classes/Service/PdfGenerationService.php
@@ -17,7 +17,7 @@
 
 use Mpdf\Mpdf;
 
-class PdfGenerationService
+final class PdfGenerationService
 {
     public function generatePdf(string $content, string $name = ''): Mpdf
     {
@@ -39,7 +39,7 @@ public function generatePdf(string $content, string $name = ''): Mpdf
         $pdf->SetProtection(['print']);
         $pdf->SetDisplayMode('fullpage');
 
-        $pdf->title = $name;
+        $pdf->setTitle($name);
         $pdf->WriteHTML($content);
 
         return $pdf;

diff --git a/rector.php b/rector.php
@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
 use PLUS\GrumPHPConfig\RectorSettings;
 use Rector\Config\RectorConfig;
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
@@ -31,7 +32,7 @@
         [
             ...RectorSettings::skip(),
             ...RectorSettings::skipTypo3(),
-
+            RemoveEmptyMethodCallRector::class, // this with Mpdf takes for ever :/
             /**
              * rector should not touch these files
              */