refactor

pluginsGLPI · Jan 29, 2025 · e15aa3e · e15aa3e
1 parent 6f8c10d
commit e15aa3e
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/inc/field/fieldsfield.class.php b/inc/field/fieldsfield.class.php
@@ -208,11 +208,7 @@ public function prepareHtmlField($fieldName, $canedit = true, $value = '') {
          $field['value'] = $value;
       } else {
          //get default value
-         if (
-            $this->getField()->fields['default_value'] !== ""
-            && $this->getField()->fields['default_value'] !== null
-            && $this->getField()->fields['default_value'] !== 0
-         ) {
+         if (!empty($this->getField()->fields['default_value'])) {
             $value = $this->getField()->fields['default_value'];
             // shortcut for date/datetime
             if (in_array($this->getField()->fields['type'], ['date', 'datetime'])
@@ -512,7 +508,7 @@ public function isValid(): bool {
    private function isAdditionalFieldEmpty(): bool {
       switch ($this->getField()->fields['type']) {
          case 'dropdown':
-            return $this->getField()->fields['mandatory'] && ($this->value == 0 || $this->value == '' || $this->value == null);
+            return $this->getField()->fields['mandatory'] && empty($this->value);
       }
 
       return $this->getField()->fields['mandatory'] && $this->value == '';