Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust parameters for compatibility with multisite hooks #295

Merged

Conversation

zhyian
Copy link
Contributor

@zhyian zhyian commented Oct 30, 2024

Hello!

This PR updates the multisite related functionality to use the WP_Site object instead of a site ID parameter, providing compatibility with the wp_initialize_site and wp_uninitialize_site hooks.

Current behavior:
When the plugin is network-activated, creating a new site in the network causes a fatal error:

Screenshot 2024-10-30 at 15 25 02

Copy link

@stklcode stklcode added the bug label Oct 30, 2024
@stklcode stklcode self-requested a review October 30, 2024 14:37
@stklcode stklcode added this to the 2.0.0 milestone Oct 30, 2024
@stklcode
Copy link
Contributor

Fixes a regression from #252 (switch from wpmu_new_blog which expected int site ID)

Thanks @zhyian for taking care of that!

@stklcode stklcode merged commit 29b3712 into pluginkollektiv:develop Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants