Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp infinite values in logarithmic coordinate system #561

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Clamp infinite values in logarithmic coordinate system #561

merged 1 commit into from
Mar 28, 2024

Conversation

NorbertGarfield
Copy link
Contributor

Solves #532

When LogCoord<V>::map gets a value equal to zero, fv.ln() yields -∞.
Map positive and negative infinity to the upper and lower limits to avoid panicking.

@NorbertGarfield
Copy link
Contributor Author

@AaronErhardt, please review.

AaronErhardt
AaronErhardt approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@AaronErhardt AaronErhardt merged commit 8f14c1e into plotters-rs:master Mar 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronErhardt AaronErhardt AaronErhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NorbertGarfield @AaronErhardt