Add Clone and PartialEq traits to SeriesLabelPosition and ShapeStyle #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Firstly thank you so much for this crate, its very useful and Rust ecosystem really needs such crate!
I have encountered some little roadblocks when using it in our Yew based application and would like to know if it was ok to integrate those changes that seem to benefit to other applications too.
What
Debug,Clone,PartialEqtraits toSeriesLabelPositionDebug,PartialEqtraits toShapeStyleWhy
Those traits can be quite useful in diverse applications (at least it is when integrating Plotters in WASM Yew based application where the Component Properties must be
PartialEqandClone).Notes
If there is any other Struct/Enum where we could add those that you think might be relevant too, I could add them in this PR too!
Thank you for your time