Fix [BUG] Rotated labels overlap with the chart #551 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `ab_glyph` font backend
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.6...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…criterion-0.4.0 Update criterion requirement from 0.3.6 to 0.4.0
Updates the requirements on [ttf-parser](https://github.com/RazrFalcon/ttf-parser) to permit the latest version. - [Release notes](https://github.com/RazrFalcon/ttf-parser/releases) - [Changelog](https://github.com/RazrFalcon/ttf-parser/blob/master/CHANGELOG.md) - [Commits](harfbuzz/ttf-parser@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: ttf-parser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Aaron Erhardt <aaron.erhardt@t-online.de>
Export the `doc` macro, to use of `define_color`
…ttf-parser-0.17.0 Update ttf-parser requirement from 0.15.0 to 0.17.0
update font backend documentation
Signed-off-by: Aaron Erhardt <aaron.erhardt@t-online.de>
Signed-off-by: Aaron Erhardt <aaron.erhardt@t-online.de>
Minor: Resolved this warning associated with a "Non-Standard" default
* Properly propagate error of nested result
Added primitive types implementation of the `LogScalable` trait
Add dashed line style.
Fix dashed line algorithm
…itmap Fix overflow in `blit_bitmap`
Add dotted line style
- also hide the count! macro, since it is only used as a helper
Enable macro usage for users to define colormaps
docs - annotate objects who depend on features
…not override the user-defined `label_style.pos`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Some(_) => label_style, | ||
| None => &label_style_with_new_pos, | ||
| }; | ||
| area.draw_text(t, &label_style, (text_x, text_y))?; |
Check warning
Code scanning / clippy
this expression creates a reference which is immediately dereferenced by the compiler Warning
The fix looks good to me, but breaking changes are not accepted on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not override the
label_style.posvalue if it has been defined by the user.This is the related discussion for issue #551 . I also commented out a rational for the fix in here
This is a breaking change, but the only breaking change is that the type of
TextStyle.poschanges fromtext_anchor::PostoOption<text_anchor::Pos>. It is a breaking change becauseTextStyle.posis a public attribute.I don't know if this kind of breaking change is allowed. I also don't know if this is a good fix for this issue. Please advise any type of change you would want me to do, and I can do it. Thank you