Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plone test versions, and pin twine #1865

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Update Plone test versions, and pin twine #1865

merged 4 commits into from
Jan 22, 2025

Conversation

davisagli
Copy link
Member

@davisagli davisagli commented Jan 22, 2025

There was a new release of twine today which requires packaging 24.0, which is not in our KGS. /cc @mauritsvanrees


📚 Documentation preview 📚: https://plonerestapi--1865.org.readthedocs.build/

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli davisagli merged commit b8f1594 into main Jan 22, 2025
20 of 24 checks passed
@davisagli davisagli deleted the fix-ci branch January 22, 2025 02:54
@mauritsvanrees
Copy link
Member

There was a new release of twine today which requires packaging 24.0, which is not in our KGS. /cc @mauritsvanrees

Plone 6.0.13 had packaging 23.2, but in Plone 6.0.14 and 6.1.0b2 we pin packaging 24.2, so that should be fine.

Also, in 6.0 the twine pin is versions-extra.cfg, so we could also include that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants