Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkcheck #1846

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Fix linkcheck #1846

merged 2 commits into from
Nov 24, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Nov 24, 2024

  • html_use_opensearch value must not have a trailing slash
  • Clean up comments

📚 Documentation preview 📚: https://plonerestapi--1846.org.readthedocs.build/

- html_use_opensearch value must not have a trailing slash
- Clean up comments
@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy stevepiercy self-assigned this Nov 24, 2024
@davisagli davisagli merged commit 9403ec4 into main Nov 24, 2024
25 checks passed
@davisagli davisagli deleted the linkcheck-2024-11-24 branch November 24, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants