Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong preview_image_link addition from blocks (de)serializers #1737

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Remove wrong preview_image_link addition from blocks (de)serializers #1737

merged 3 commits into from
Nov 27, 2023

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from davisagli November 25, 2023 21:42
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2023 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 89dcd78
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6563257c0c9430000805e116

@mister-roboto
Copy link

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@sneridagh
Copy link
Member Author

@jenkins-plone-org please run jobs

davisagli
davisagli reviewed Nov 26, 2023
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh It also should be removed from the deserializer: https://github.com/plone/plone.restapi/blob/main/src/plone/restapi/deserializer/blocks.py#L58

@sneridagh
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit d5b83a6 into main Nov 27, 2023
18 checks passed
@davisagli davisagli deleted the removepreviewimagelink branch November 27, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneridagh @mister-roboto @davisagli