Add preview_image and preview_image_link to the list of smart fields for resolveuid and link integrity
#1735
Conversation
…for resolveuid and link_integrity
✅ Deploy Preview for plone-restapi canceled.
|
sneridagh
changed the title
preview_image and preview_image_link to the list of smart fields for resolveuid and link_integrity
|
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
sneridagh
changed the title
preview_image and preview_image_link to the list of smart fields for resolveuid and link_integritypreview_image and preview_image_link to the list of smart fields for resolveuid and link integrity
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
@sneridagh @tisto Please don't release this, it doesn't look right to me.
| @@ -111,7 +110,7 @@ def __call__(self, block): | |||
| Returns a list of internal links | |||
| """ | |||
| links = [] | |||
| for field in ["url", "href"]: | |||
| for field in ["url", "href", "preview_image", "preview_image_link"]: | |||
There was a problem hiding this comment.
This doesn't make any sense, there will not be a preview_image or preview_image_link inside a slate block value.
There was a problem hiding this comment.
Sorry, I was reading it wrong, this is the generic blocks retriever. It makes sense for preview_image, which is used in the teaser block. It doesn't make sense for preview_image_link, which is a relation field not in blocks. I don't think we need to do anything special to make linkintegrity work for a relation field.
No description provided.