From d5b83a67b5a894b7985c67e6c2ae0c9eb1034fd6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Fern=C3=A1ndez=20de=20Alba?= Date: Mon, 27 Nov 2023 02:17:43 +0100 Subject: [PATCH] Remove wrong `preview_image_link` addition from blocks (de)serializers (#1737) * Remove wrong `preview_image_link` addition from blocks (de)serializers * Changelog * Remove last one --- news/1737.bugfix | 2 ++ src/plone/restapi/blocks_linkintegrity.py | 2 +- src/plone/restapi/deserializer/blocks.py | 2 +- src/plone/restapi/serializer/blocks.py | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 news/1737.bugfix diff --git a/news/1737.bugfix b/news/1737.bugfix new file mode 100644 index 0000000000..a4953486ab --- /dev/null +++ b/news/1737.bugfix @@ -0,0 +1,2 @@ +Remove wrong `preview_image_link` addition from blocks (de)serializers +[sneridagh] diff --git a/src/plone/restapi/blocks_linkintegrity.py b/src/plone/restapi/blocks_linkintegrity.py index 5a907baa67..754f5c256b 100644 --- a/src/plone/restapi/blocks_linkintegrity.py +++ b/src/plone/restapi/blocks_linkintegrity.py @@ -110,7 +110,7 @@ def __call__(self, block): Returns a list of internal links """ links = [] - for field in ["url", "href", "preview_image", "preview_image_link"]: + for field in ["url", "href", "preview_image"]: value = block.get(field, "") for url in get_urls_from_value(value): links.append(url) diff --git a/src/plone/restapi/deserializer/blocks.py b/src/plone/restapi/deserializer/blocks.py index 655805903f..59e26a807c 100644 --- a/src/plone/restapi/deserializer/blocks.py +++ b/src/plone/restapi/deserializer/blocks.py @@ -55,7 +55,7 @@ class ResolveUIDDeserializerBase: order = 1 block_type = None - fields = ["url", "href", "preview_image", "preview_image_link"] + fields = ["url", "href", "preview_image"] disabled = os.environ.get("disable_transform_resolveuid", False) def __init__(self, context, request): diff --git a/src/plone/restapi/serializer/blocks.py b/src/plone/restapi/serializer/blocks.py index 76669b7092..e255ff7449 100644 --- a/src/plone/restapi/serializer/blocks.py +++ b/src/plone/restapi/serializer/blocks.py @@ -40,7 +40,7 @@ def __call__(self): class ResolveUIDSerializerBase: order = 1 block_type = None - fields = ["url", "href", "preview_image", "preview_image_link"] + fields = ["url", "href", "preview_image"] disabled = os.environ.get("disable_transform_resolveuid", False) def __init__(self, context, request):