-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution by @galeedgutierrez #53
Open
GaleedGutierrez
wants to merge
20
commits into
platzi:main
Choose a base branch
from
GaleedGutierrez:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se modificó eslint y editorconfig, se agregaron los archivos de prettier y stylelint
Según si hay o no elementos en la todo list .main y .footer se ocultarán o mostrarán.
Ahora podemos agregar una nueva tarea
feat: ✨ 2) Crear una nueva tarea
Tarea marcada como "complete" o "pending" según el estado del checkbox de la tarea
Al hacer doble click se puede editar la tarea selecionada Se actualizó la versión de Playwright para poder usar la extensión de testing de VSCode.
Punto 3 una tarea
…la edición. Cuando el modo edición está activado, se deberían ocultar los otros elementos y se mostrará un input que contiene el título de la tarea pendiente, que debe estar enfocado.
Punto 4 editando una tarea
Cuando se agrega o elimina una tarea, el contador cambia, aumenta o disminuye según sea el caso.
feat: ✨ 5) Contador
El botón de eliminar una tarea funciona.
Podemos limpiar todas las tareas ya completadas y ocultar el botón cuando no hay ninguna tarea completada.
Punto 6 boton de limpiar
Ahora podemos guardar, eliminar y editar las tareas.
Cuando reiniciamos el navegador, persiste la última información añadida y/o modificada. Se modificó app.spec.js, ya que no contemplaba el estado de "pending" y había un error en donde el test fallaba por falta de un await en "Persistence" línea 247.
Punto 7 persistencia
Se puede filtrar las tareas pendientes, completas y ver ambas a la vez.
feat: ✨ 8) Filtros y rutas
This is the deploy: https://galeedgutierrez.com/laboratorio-mydayapp-js/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enjoyed this exercise. 😀